Skip to content

tests: add tests for SHA256 #1604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 9, 2024
Merged

tests: add tests for SHA256 #1604

merged 1 commit into from
Feb 9, 2024

Conversation

vil02
Copy link
Member

@vil02 vil02 commented Feb 1, 2024

Open in Gitpod know more

Describe your change:

This PR adds tests for SHA256.
The data was verified with https://emn178.github.io/online-tools/sha256.html.

Similar to #1602.

  • Add missing tests.

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@vil02 vil02 force-pushed the add_tests_for_sha256 branch from 0f5845b to dbabed8 Compare February 1, 2024 18:08
@vil02 vil02 marked this pull request as ready for review February 1, 2024 18:10
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6aaa376) 82.44% compared to head (dbabed8) 83.44%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1604      +/-   ##
==========================================
+ Coverage   82.44%   83.44%   +0.99%     
==========================================
  Files         377      377              
  Lines       19747    19747              
  Branches     2884     2906      +22     
==========================================
+ Hits        16281    16477     +196     
+ Misses       3466     3270     -196

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

appgurueu
appgurueu approved these changes Feb 1, 2024
View reviewed changes
Copy link
Collaborator

@appgurueu appgurueu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified using the sha256sum command.

@raklaptudirm raklaptudirm merged commit f313498 into TheAlgorithms:master Feb 9, 2024
@vil02 vil02 deleted the add_tests_for_sha256 branch February 9, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appgurueu appgurueu appgurueu approved these changes

@raklaptudirm raklaptudirm raklaptudirm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vil02 @codecov-commenter @appgurueu @raklaptudirm